From 892e58634076fcb09ec56bc0b919bf3dc1d4e4fe Mon Sep 17 00:00:00 2001 From: Matthew Jackson <1085847+MattJackson@users.noreply.github.com> Date: Wed, 1 Jul 2026 10:44:39 -0700 Subject: [PATCH] =?UTF-8?q?unlock:=20drop=20applies=5Fto=20=E2=80=94=20the?= =?UTF-8?q?=20matrix=20reports=20did-work,=20not=20matched?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/ld/mod.rs | 8 -------- src/lib.rs | 9 --------- 2 files changed, 17 deletions(-) diff --git a/src/ld/mod.rs b/src/ld/mod.rs index 1fa3bcd..7ca6d8a 100644 --- a/src/ld/mod.rs +++ b/src/ld/mod.rs @@ -129,14 +129,6 @@ impl Unlocker for LibreDrive { ctx.kind == crate::DiscKind::Unknown && profile::find_bundled(ctx.drive_id).is_some() } - /// For the report, the drive unlocker applies whenever it recognises the - /// DRIVE — independent of disc kind (its live `matches` is gated to the - /// Unknown-kind init phase, which would falsely read "no" once the disc kind - /// is known). - fn applies_to(&self, ctx: &UnlockCtx) -> bool { - profile::find_bundled(ctx.drive_id).is_some() - } - /// Firmware-unlock the drive and report its OEM Volume ID. The unlocked drive /// serves CLEAR content, so `drive_unlocked: true` and there is no bus key. /// diff --git a/src/lib.rs b/src/lib.rs index 0d8dfd5..fd52f9f 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -121,15 +121,6 @@ pub trait Unlocker: Send + Sync { /// whether to RUN it. fn matches(&self, ctx: &UnlockCtx) -> bool; - /// Report-only: would this unlocker apply to this drive + disc, for a - /// user-facing unlocker matrix? Distinct from [`matches`](Unlocker::matches), - /// which is phase-gated (e.g. the drive-prep unlocker only `matches` at the - /// Unknown-kind init phase). Default: same as `matches`; the drive-keyed - /// unlocker overrides it to report on drive identity regardless of disc kind. - fn applies_to(&self, ctx: &UnlockCtx) -> bool { - self.matches(ctx) - } - /// Remove the bus-encryption barrier, returning what was learned. fn unlock( &self,