pq/libfreemkv
1
Fork 0
mirror of https://github.com/freemkv/libfreemkv.git synced 2026-10-07 18:13:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(msrv): floor to 1.88, pin CI on the floor, allow uninlined_format_args

Browse Source 
Declared rust-version and the ci.yml/qa.yml toolchain pins both sit at 1.88 (the
edition-2024 floor once zip 8 and let-chains are accounted for), so CI builds on
exactly the MSRV: an accidental bump to a newer toolchain fails CI by design and
moving the floor takes a deliberate pin edit. The uninlined_format_args allow
reconciles 1.88's clippy with the allow-by-default it became in 1.97+.
This commit is contained in:
Matthew Jackson
2026-08-31 11:06:35 -07:00
parent 2e90a7585d
commit 0c953e9340
3 changed files with 12 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci.yml
+5 -5
View File
@@ -57,7 +57,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}" ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}"
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
with: with:
components: clippy, rustfmt components: clippy, rustfmt
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
@@ -95,7 +95,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}" ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}"
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
with: with:
workspaces: libfreemkv workspaces: libfreemkv
@@ -135,7 +135,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}" ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}"
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
with: with:
workspaces: libfreemkv workspaces: libfreemkv
@@ -175,7 +175,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}" ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}"
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
with: with:
workspaces: libfreemkv workspaces: libfreemkv
@@ -279,7 +279,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}" ref: "${{ github.ref_name == 'qa' && 'qa' || 'dev' }}"
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
with: with:
components: llvm-tools-preview components: llvm-tools-preview
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
.github/workflows/qa.yml
+3 -3
View File
@@ -79,7 +79,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: qa ref: qa
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
with: with:
workspaces: libfreemkv workspaces: libfreemkv
@@ -100,7 +100,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: qa ref: qa
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
with: with:
components: clippy components: clippy
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
@@ -125,7 +125,7 @@ jobs:
repository: freemkv/freemkv-unlock repository: freemkv/freemkv-unlock
ref: qa ref: qa
path: freemkv-unlock path: freemkv-unlock
- uses: dtolnay/rust-toolchain@1.94.0 - uses: dtolnay/rust-toolchain@1.88.0
- uses: Swatinem/rust-cache@v2 - uses: Swatinem/rust-cache@v2
with: with:
workspaces: libfreemkv workspaces: libfreemkv
Cargo.toml
+4 -1
View File
@@ -2,7 +2,7 @@
name = "libfreemkv" name = "libfreemkv"
version = "1.6.13" version = "1.6.13"
edition = "2024" edition = "2024"
rust-version = "1.94" rust-version = "1.88"
license = "MIT" license = "MIT"
description = "Open source raw disc access library for optical drives" description = "Open source raw disc access library for optical drives"
repository = "https://github.com/freemkv/libfreemkv" repository = "https://github.com/freemkv/libfreemkv"
@@ -105,3 +105,6 @@ tempfile = "3"
name = "sgio_read" name = "sgio_read"
harness = false harness = false
[lints.clippy]
uninlined_format_args = "allow"