test: constrain MP4 composition timing, MLP substream directory, and codec-private absence

Mutation testing over src/mux/. No production change — 49 survivors
killed, all proven red before green.

The MP4 composition-time chain was entirely unconstrained: VideoTiming::ctts,
build_ctts and parse_ctts could each return a constant and the suite
stayed green. Confirmed on HEAD: build_ctts -> vec![] passes all 1,220
mux tests. A demuxed B-frame title presenting in decode order would
have shipped.

The cause is a test whose name asserts coverage its body does not
deliver — stts_and_ctts_expand builds an stts box and never touches
ctts, and write_then_read_round_trip asserts sample sizes and keyframe
flags but not one PTS. Same shape as the set_speed forwarding finding,
different disguise.

mlp_num_substreams / mlp_substr_header_size: every TrueHD fixture in
the crate uses one substream and no extraword, so both could return a
constant and agree with all of them. These position mlp_parity_ok's
window over the AU header, so a constant mis-windows the parity check
on exactly the multi-substream AUs that carry 7.1 and Atmos.

CodecPrivate absent vs empty: mkv.rs writes Some(bytes) verbatim and
omits the element on None (RFC 9559 5.1.4.1.24), so a zero-length Some
emits a track header asserting the config IS empty. Four parsers could
return Some(vec![]) before any frame.

Also: mandatory ISO/IEC 14496-12 boxes (tkhd, vmhd, smhd, dinf, mdhd)
could each build empty; HEVC num_extra_slice_header_bits (H.265 7.3.2.3)
was never non-zero in any fixture, so the slice-type offset skip was
unexercised; chapter names from the disc go straight into
<ChapterString> and the & escape must run first; a stray 0x47 in a
payload must not latch a TS resync.

Documented as equivalent rather than killed: CodecParser::flush and the
three parser flush bodies that differ from the mutant only by a tracing
call, and DropTally::log_summary.
This commit is contained in:
Matthew Jackson
2026-07-30 13:39:02 -07:00
parent 55b97ac576
commit 170fd0c064
14 changed files with 1027 additions and 0 deletions
+75
View File
@@ -1447,6 +1447,81 @@ mod tests {
assert_eq!(h.max_display_mastering_luminance, 10_000_000);
}
/// `num_extra_slice_header_bits` (H.265 §7.3.2.3) is a PPS field, and the
/// `slice_reserved_flag[i]` bits it counts sit BETWEEN
/// `slice_pic_parameter_set_id` and `slice_type` in the slice segment header
/// (§7.3.6.1). Every existing fixture used a PPS with the field == 0, so the
/// skip was never exercised: a parser that ignored the field entirely agreed
/// with all of them, and would then read `slice_type` from the wrong bit
/// offset on any real stream that sets it — mislabelling every picture's
/// coding type.
#[test]
fn nonzero_num_extra_slice_header_bits_shifts_the_slice_type_offset() {
use super::super::coding::CodingType;
// PPS body bits: pps_id ue=0 ('1'), sps_id ue=0 ('1'),
// dependent_slice_segments_enabled_flag 0, output_flag_present_flag 0,
// num_extra_slice_header_bits u(3).
let pps_body = |num_extra: u8| 0b1100_0000u8 | (num_extra << 1);
assert_eq!(pps_body(0), 0xC0, "matches the existing zero-extra fixture");
assert_eq!(pps_body(3), 0xC6);
let pps_nal = |num_extra: u8| {
let mut v = hevc_nal_header(NAL_PPS).to_vec();
v.push(pps_body(num_extra));
v
};
for n in 0..8u8 {
assert_eq!(
hevc_num_extra_slice_header_bits(&pps_nal(n)),
Some(n as u32),
"PPS must yield the value it encodes, for every u(3) code point"
);
}
// A PPS truncated to just its 2-byte NAL header carries no field to read,
// so the answer is absent — never a defaulted zero.
assert_eq!(
hevc_num_extra_slice_header_bits(&hevc_nal_header(NAL_PPS)),
None
);
// Slice segment header for a non-IRAP VCL NAL (TRAIL_R, type 1):
// first_slice_segment_in_pic_flag 1, slice_pic_parameter_set_id ue=0
// ('1'), then THREE reserved bits set to 101 (deliberately not zero, so a
// parser that reads them instead of skipping them cannot agree), then
// slice_type ue(v) = '011' → 2 → I.
let slice_body = 0b1_1_101_011u8;
assert_eq!(slice_body, 0xEB);
let nal = |t: u8, body: u8| {
let mut v = vec![0x00, 0x00, 0x01];
v.extend_from_slice(&hevc_nal_header(t));
v.push(body);
v
};
let mut data = nal(NAL_PPS, pps_body(3));
data.extend_from_slice(&nal(1, slice_body));
let frames = HevcParser::new().parse(&make_pes(data, Some(0)));
assert_eq!(frames.len(), 1);
assert_eq!(
frames[0].coding.expect("PictureInfo").coding_type(),
CodingType::I,
"with num_extra=3 the reserved bits are skipped and slice_type reads 2 (I)"
);
// Control: the SAME slice bytes under a PPS declaring num_extra=0 land on
// a different slice_type — proving the PPS field, not the slice bytes,
// decides the offset.
let mut data0 = nal(NAL_PPS, pps_body(0));
data0.extend_from_slice(&nal(1, slice_body));
let frames0 = HevcParser::new().parse(&make_pes(data0, Some(0)));
assert_eq!(
frames0[0].coding.expect("PictureInfo").coding_type(),
CodingType::B,
"num_extra=0 reads slice_type from bit 2 instead → 0 (B)"
);
}
#[test]
fn hevc_populates_measured_coding_type_and_source() {
use super::super::coding::CodingType;