From 237794a6ea86917668d7a6b7642203502ab03b16 Mon Sep 17 00:00:00 2001 From: Matthew Jackson <1085847+MattJackson@users.noreply.github.com> Date: Sat, 8 Aug 2026 08:46:17 -0700 Subject: [PATCH] ci: run the dependents' test suites, not just a type-check MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `consumers` job checked out all five dependents against this commit and ran `cargo check --all-targets`. That proves they still COMPILE, which catches a changed signature and nothing else. The failures worth catching here keep every signature intact and change behaviour: the library still builds, the dependent still builds, and the dependent's tests are what go red. Those never ran. Run their suites instead. Same checkouts, same patched paths — only the verb changes. --- .github/workflows/ci.yml | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 877b8c1..003e249 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -187,13 +187,17 @@ jobs: freemkv autorip bdemu - - run: cargo check --all-targets + # `cargo check` alone only proves the dependents still COMPILE against + # this commit. It cannot see a behavioural change — the library keeps its + # signatures and a dependent's tests start failing. That is the shape of + # every defect worth catching here, so run their suites too. + - run: cargo test --tests working-directory: freemkv-keysources - - run: cargo check --all-targets + - run: cargo test --tests working-directory: freemkv-engine - - run: cargo check --all-targets + - run: cargo test --tests working-directory: freemkv - - run: cargo check --all-targets + - run: cargo test --tests working-directory: autorip - - run: cargo check --all-targets + - run: cargo test --tests working-directory: bdemu