io/pipeline: replace polling-send with kernel-wakeup channel
The halt-aware send loop polled try_send on a 50 ms sleep slice when the channel was full. That capped producer throughput at 1 / 50 ms = 20 frames/sec ≈ 1 MB/s at typical PES frame sizes — way below NFS, let alone local SSD/NVMe. Multi-day diagnostic 2026-05-13/14 surfaced it as the root cause of the 18 → 3 MB/s mux throughput regression on 0.21.x. Replaced std::sync::mpsc::sync_channel with crossbeam_channel::bounded and switched send_with_halt to send_timeout. Producer now BLOCKS on consumer drain (kernel-wakeup) instead of polling — the timeout slice (250 ms) only fires when the producer is waiting for stop signal observation, never on the happy path. Result: no throughput cap from this primitive at any medium speed. Mux is bounded by actual storage / network bandwidth, not by our channel implementation. Same fix needs to land in autorip's mux.rs producer-side sync_channel (separate sibling commit). Documented in freemkv-private/memory/ feedback_send_with_halt_poll_throttle.md.
This commit is contained in:
@@ -28,6 +28,12 @@ base64 = "0.22.1"
|
||||
# under CLAUDE.md ("Acceptable strings: debug/trace logging"). Consumers (autorip)
|
||||
# wire a tracing subscriber and pipe events into the JSONL debug log.
|
||||
tracing = "0.1"
|
||||
# Bounded MPSC channel with kernel-wakeup send_timeout. Used by `io::pipeline`
|
||||
# so the halt-aware send/finish loops can BLOCK on consumer drain instead of
|
||||
# polling — the 50 ms poll cadence of the previous mpsc-based impl capped mux
|
||||
# throughput at ~1 MB/s (see freemkv-private/memory/
|
||||
# feedback_send_with_halt_poll_throttle.md, 0.21.7).
|
||||
crossbeam-channel = "0.5"
|
||||
|
||||
[target.'cfg(target_os = "linux")'.dependencies]
|
||||
libc = "0.2"
|
||||
|
||||
Reference in New Issue
Block a user