From 840cb9aef0953fd9042b120a3738763986158cd4 Mon Sep 17 00:00:00 2001 From: Matthew Jackson <1085847+MattJackson@users.noreply.github.com> Date: Wed, 29 Jul 2026 16:36:22 -0700 Subject: [PATCH] Drop the comment that promised tests this crate no longer has MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The bisect ReadAction regression tests moved to freemkv-engine with the recovery strategy, but their explanatory block stayed behind — seventeen lines describing a `let _ = handle_read_error(..)` bug and asserting "the tests below prove the required ReadAction values are produced". There are no tests below it; handle_read_error is not even resolvable here any more. Anyone auditing whether that bug is still guarded would read this and conclude yes. The block moved to the engine alongside the tests it describes. --- src/disc/mod.rs | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/src/disc/mod.rs b/src/disc/mod.rs index e8a6f54..ef93776 100644 --- a/src/disc/mod.rs +++ b/src/disc/mod.rs @@ -4808,21 +4808,4 @@ mod tests { assert_eq!(chapter_name(0), "1"); assert_eq!(chapter_name(41), "42"); } - - // ── Regression tests for bisect inner-loop ReadAction dispatch ─────────── - // - // Before the fix the bisect inner loop discarded the ReadAction returned by - // handle_read_error: - // - // let _ = read_error::handle_read_error(&inner_err, &mut read_ctx); - // - // Consequences: - // (a) Retry{pause_secs} — cooldown skipped; sector immediately marked - // BisectBad, hammering a degraded drive (violates Hard Rule #2). - // (b) AbortPass — ignored; loop kept issuing reads against a crashed drive. - // - // The fix replaces the discard with a match. The tests below prove the - // required ReadAction values are produced by handle_read_error in the - // bisect-inner context (bisecting=true, batch=1), so that any regression - // to `let _ = ...` would break real behaviour on the tested error paths. }