v0.13.1: scsi::reset() bounded by wallclock timeout

Production incident: autorip's poll loop called scsi::reset() on a
wedged BU40N USB drive. The Linux SG_SCSI_RESET ioctl blocked
indefinitely (kernel SCSI subsystem waiting for a bus-wedged device to
ack a reset that will never come). Caller's poll loop hung for 60+
seconds before manual intervention.

scsi::reset() now spawns a detached worker for the platform-specific
reset and bounds the caller's wait via mpsc::recv_timeout. Default
30 s (DEFAULT_RESET_TIMEOUT_SECS); reset_with_timeout(device, dur)
exposes the bound for callers that want a different value. Returns
DeviceResetFailed on timeout. Worker thread keeps running until the
kernel eventually unblocks — leaks one OS thread per hard wedge, but
the daemon stays responsive instead of hanging forever.

Follow-up flagged for 0.13.2: USB-attached drives wedge at the USB
Mass Storage layer below SCSI; SG_SCSI_RESET doesn't help. A
scsi::usb_reset(path) using USBDEVFS_RESET is the proper escalation.

This commit is contained in:

MattJackson

2026-04-24 16:58:13 -07:00

parent d1f09439a5

commit 8af47e4c19

3 changed files with 105 additions and 3 deletions

									
										Cargo.toml
									
		+1
		-1
	
												View File
												
				@@ -1,6 +1,6 @@

				[package]

				name = "libfreemkv"

				version = "0.13.0"

				version = "0.13.1"

				edition = "2024"

				rust-version = "1.86"

				license = "AGPL-3.0-only"