From afa04aa6cda5ce039e8a7c6553242302ccd2a7c9 Mon Sep 17 00:00:00 2001 From: Matthew Jackson Date: Sat, 9 May 2026 20:40:31 -0700 Subject: [PATCH] ci: drop --locked from libfreemkv workflows MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit libfreemkv is a library — Cargo.lock is gitignored (standard for libs). --locked refuses to create a lockfile on a fresh runner, so it always fails CI. --locked stays in the binary crates (freemkv, autorip, bdemu) which DO track Cargo.lock and benefit from the dependency-race hard-fail behaviour. --- .github/workflows/ci.yml | 8 ++++++-- .github/workflows/release.yml | 6 ++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 7802154..a63591e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -14,14 +14,18 @@ jobs: with: components: clippy, rustfmt - run: cargo fmt --check - - run: cargo clippy --locked -- -D warnings + # libfreemkv is a library — Cargo.lock is gitignored. --locked + # would always fail on a fresh runner because there's no committed + # lockfile to lock against. The binary crates (freemkv, autorip, + # bdemu) track Cargo.lock and DO use --locked. + - run: cargo clippy -- -D warnings test: runs-on: ubuntu-latest steps: - uses: actions/checkout@v5 - uses: dtolnay/rust-toolchain@1.86.0 - - run: cargo test --locked --tests + - run: cargo test --tests check-macos: runs-on: macos-latest diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index b47b7ea..b73f991 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -28,7 +28,9 @@ jobs: steps: - uses: actions/checkout@v5 - uses: dtolnay/rust-toolchain@1.86.0 - - run: cargo test --locked + # libfreemkv is a library — Cargo.lock isn't tracked, so --locked + # would always fail (no lockfile to lock against on a fresh runner). + - run: cargo test publish: needs: test @@ -37,7 +39,7 @@ jobs: - uses: actions/checkout@v5 - uses: dtolnay/rust-toolchain@1.86.0 - name: Publish to crates.io - run: cargo publish --locked + run: cargo publish env: CARGO_REGISTRY_TOKEN: ${{ secrets.CARGO_REGISTRY_TOKEN }}