From b405154fd025970e1746f65c35e44d8de9ea84c8 Mon Sep 17 00:00:00 2001 From: Matthew Jackson <1085847+MattJackson@users.noreply.github.com> Date: Tue, 25 Aug 2026 13:49:35 -0700 Subject: [PATCH] ci: run the consumers job at the highest dependent MSRV (1.98) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The MSRV split raised the dependents above libfreemkv's own floor — the bins (freemkv, autorip, bdemu) are 1.98 and freemkv-keysources is 1.97 — so the consumers job could no longer build them at libfreemkv's 1.94 toolchain (`rustc 1.94.0 is not supported by ... freemkv-keysources requires rustc 1.97`), leaving dev red since the MSRV change. Pin that one job to 1.98, which satisfies every dependent's floor. libfreemkv's own lib/lint/test jobs stay at its 1.94 MSRV. --- .github/workflows/ci.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ef63e86f..c98c5843 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -230,7 +230,10 @@ jobs: freemkv-i18n = { path = "../freemkv-i18n" } EOF done - - uses: dtolnay/rust-toolchain@1.94.0 + # The consumers span a higher MSRV than libfreemkv itself (the bins are + # 1.98, keysources 1.97), so build them with a toolchain that satisfies the + # HIGHEST dependent floor — libfreemkv's own 1.94 cannot compile them. + - uses: dtolnay/rust-toolchain@1.98.0 - uses: Swatinem/rust-cache@v2 with: workspaces: |