From e4b1e5b19eaafb891de7e599314c0bcb377760df Mon Sep 17 00:00:00 2001 From: Matthew Jackson <1085847+MattJackson@users.noreply.github.com> Date: Thu, 30 Jul 2026 13:21:04 -0700 Subject: [PATCH] docs: correct info invocation and read timeouts TROUBLESHOOTING step 2 said `freemkv info`, which needs a source URL; the drive route is `freemkv info disc://`. architecture.md quoted 1.5 s / 30 s for the read timeouts. The constants are READ_TIMEOUT_MS = 10_000 and READ_RECOVERY_TIMEOUT_MS = 60_000 (src/scsi/mod.rs:72,94). --- TROUBLESHOOTING.md | 2 +- docs/architecture.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/TROUBLESHOOTING.md b/TROUBLESHOOTING.md index 853f9ff..551463e 100644 --- a/TROUBLESHOOTING.md +++ b/TROUBLESHOOTING.md @@ -302,7 +302,7 @@ Many external drive enclosures (Vantec NexStar, Sabrent, OWC, etc.) do not adver When something goes wrong during a rip, gather this information before filing an issue: 1. **freemkv version:** `freemkv --version` or the crate version in `Cargo.toml`. -2. **Drive model:** from the drive label, or from `freemkv info`. +2. **Drive model:** from the drive label, or from `freemkv info disc://`. 3. **Connection type:** USB (with bridge chipset if known) or direct SATA. 4. **Operating system and kernel:** `uname -a`. 5. **Kernel messages during the failure:** `dmesg | tail -50` immediately after the crash. diff --git a/docs/architecture.md b/docs/architecture.md index 989380c..f43d720 100644 --- a/docs/architecture.md +++ b/docs/architecture.md @@ -96,7 +96,7 @@ After open: - `init()` -- routes to the matching registered unlocker (if any); otherwise a no-op and the cert handshake carries the disc - `probe_disc()` -- probe disc surface for optimal speeds -- `read(lba, count, buf, recovery)` -- single-shot read; `recovery` only selects the per-CDB timeout (1.5 s vs. 30 s) +- `read(lba, count, buf, recovery)` -- single-shot read; `recovery` only selects the per-CDB timeout (`READ_TIMEOUT_MS` 10 s vs. `READ_RECOVERY_TIMEOUT_MS` 60 s) - `wait_ready()` -- wait for disc insertion - `eject()` -- eject tray