From f53abfe0d4348e0ef5e5c3703f78540e72fe11c5 Mon Sep 17 00:00:00 2001 From: Matthew Jackson <1085847+MattJackson@users.noreply.github.com> Date: Sun, 2 Aug 2026 15:30:56 -0700 Subject: [PATCH] Stop naming a specific commercial disc in the label parser MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Two comments identified the disc the STN-numbering bug was found on by its vendor project name. The reproduction does not need it: what matters is the SHAPE of the token list — placeholder slots, region-only tokens, an uncatalogued component — not which release happened to exhibit it. Both now describe the shape. The remaining `SEG_MainFeature` references stay. That is a vendor section name the parser matches on at pixelogic.rs:88, not a disc identifier — it is the format's vocabulary, like `FPL_` or the `eng_MLP_` stream tokens beside it, and removing it would break the parser. Also drops the last prohibited citation from the changelog: an mp4:// bullet said "no ffmpeg". The website changelog page is REGENERATED from this file at release time, so a scrub of the site alone would have been reverted by the next release. --- CHANGELOG.md | 2 +- src/labels/pixelogic.rs | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 977603e..119c61a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -335,7 +335,7 @@ any sink (`mp4:// mkv://`, `mp4:// audio://`, `mp4:// json://`, …). The round-trip is frame-exact. - **Native MP4 output (`mp4://`)** — a disc goes straight to a play-everywhere - `.mp4` in one decrypt pass, no ffmpeg. Carries HEVC / H.264 video (with HDR10) and + `.mp4` in one decrypt pass, no external transcoder. Carries HEVC / H.264 video (with HDR10) and AC-3, E-AC-3, and DTS / DTS-HD audio, and is faststart by default so it plays over HTTP without downloading the end first. It's a **compatibility export, not archival**: MP4 can't hold TrueHD, LPCM, or bitmap (PGS / VobSub) subtitles, so diff --git a/src/labels/pixelogic.rs b/src/labels/pixelogic.rs index a3a8989..9885d34 100644 --- a/src/labels/pixelogic.rs +++ b/src/labels/pixelogic.rs @@ -124,10 +124,10 @@ fn assign_labels(strings: &[String], saw_unknown: &mut bool) -> Vec // `None`) or one whose only distinguishing component is uncatalogued // (`jpn_DUB_`). Numbering only the slots that PARSE renumbers the rest // 1..N and lands every surviving label on the wrong stream: on - // UHD_Crime101_WW_150728 the seven `*_TXT_FOR_` forced tokens at PG STN - // 11-16/18 collapsed onto STN 2-8, flagging the disc's FULL subtitle - // tracks `forced` and leaving the real forced-narrative tracks - // unflagged. + // one observed UHD feature the seven `*_TXT_FOR_` forced tokens at PG + // STN 11-16/18 collapsed onto STN 2-8, flagging that disc's FULL + // subtitle tracks `forced` and leaving the real forced-narrative + // tracks unflagged. // // A slot the grammar cannot classify carries no stream type either, so // it advances the list currently being enumerated: pixelogic sections @@ -479,7 +479,7 @@ mod tests { assert_eq!(audio[0].language, "eng"); } - /// Real disc (UHD_Crime101_WW_150728, `SEG_MainFeature`): the PG list has + /// Taken from a real UHD feature's `SEG_MainFeature`: the PG list has /// 18 slots, five of them bare `PG Stream N` placeholders and four more /// carrying a token whose only non-language component is a REGION /// (`fra_CF_`, `spa_LS_`, …) — which `parse_token_inner` rejects because