2 Commits

Include renames

Author	SHA1	Message	Date
matthew	307bee11e4	labels: shared platform (vocab/text/jar) + dbp refactor ... Establishes the shared infrastructure layer for label parsers so that Java-touching parsers (dbp, deluxe) don't reimplement jar walking and all parsers route language/purpose/qualifier classification through one source of truth instead of N hand-rolls. New modules: vocab.rs expanded from 27 -> ~370 lines + lang(text) -> Option<&'static str> (English/multi-word -> ISO 639-2; ~45 languages, compound phrases like 'Brazilian Portuguese' and 'Castilian Spanish') + purpose(text) -> LabelPurpose (Commentary, Descriptive, Score, Ime; word-boundary matched) + qualifier(text) -> LabelQualifier (SDH, Forced, DescriptiveService) + has_word internal primitive — enforces word-boundary matching so 'Commenter' no longer matches 'commentary' and 'engineering' no longer matches 'english'. Existing parsers used .contains() and got lucky on the corpus; vocab now guarantees the boundary in one place. 20+ unit tests. text.rs NEW (~85 lines) + extract_ascii_strings(data, min_len) — promoted from two near-duplicate copies (pixelogic min=4, dbp min=5); threshold passed in. 7 unit tests including trailing-without-terminator + high-bit-byte handling. jar.rs NEW (~120 lines) + for_each_jar(reader, udf, fn) — walk every top-level .jar under /BDMV/JAR/, yield to callback. + has_path_prefix(archive, prefix) — cheap 'is this MY framework's jar?' check via central-dir filenames. + for_each_class(archive, fn) — parse every .class entry through class_reader, yield (name, &ClassFile). + try_each_class(archive, fn) — same with early-return on first Some(R) match. Refactored: dbp.rs v2 on the new platform: - dropped extract_printable raw byte scan - dropped its own English -> ISO 639-2 map - dropped its own parse_attributes hand-roll + iterates CpInfo::Utf8 via class_reader (structurally clean, no false-positive risk from method bytecode bytes) + routes language/purpose/qualifier through vocab All 7 prior dbp tests still pass; +2 new ones cover vocab routing. dead-code allows on text.rs (extract_ascii_strings) and jar.rs (try_each_class) come off when pixelogic and deluxe land — they're staged for next steps. Precommit green (cargo +1.86 fmt + clippy + test).	2026-05-10 15:16:25 -07:00
matthew	2495acc677	labels: add dbp parser (Magnolia Pictures BD-J framework) ... 5th BD-J authoring framework recognized. Discriminator: any top- level .jar in /BDMV/JAR/ that contains com/dbp/ package paths. Identified during the 2026-05-10 corpus session via string-mining disc-07's BD-J jar — perm files reference bd-live.magpictures.com (Magnolia / Magnet Releasing). Stream labels live as plain ASCII strings inside compiled .class files in the form LTextField,Audio1,English Dolby Atmos,Fontstrip_Composite,... HTextField,Subtitle1,English SDH,Fontstrip_Composite,... ATextField,Subtitle0,None,Fontstrip_Composite,... — a quirk of the menu-rendering layer encoding TextField positions and content as constant strings the Java compiler retained in the class string pool. The leading single-letter prefix is string-pool ordering noise; parser anchors on `TextField,`. Subtitle0 is the disable-subtitles button and is skipped. The parser: - reads each top-level .jar via udf.read_file - opens it with the existing zip dependency - confirms com/dbp/ presence in the central directory - walks .class entries, extracts printable strings, matches the `TextField,(Audio|Subtitle)<N>,<label>,...` pattern - maps human-readable language names ("English", "Castilian Spanish", "Brazilian Portuguese", "Canadian French", ...) to ISO 639-2 codes via a parser-local table (per the rules-of- engagement memo, each parser knows its own format) - preserves the full disc-authored label string in `name` so consumers display it raw without the lib guessing further structure - detects SDH / Forced qualifiers and Commentary / Descriptive purposes from substring matches; everything else falls through to fill_defaults using BD-spec MPLS data Verified live on the corpus: disc-07 (Civil War UHD) now matches parser=dbp with 3 audio + 2 subtitle labels, exactly the count visible in the disc's authored TextField definitions and what BD spec MPLS reports. Limitation: dbp's detect() returns true for ANY top-level .jar in /BDMV/JAR/ (every BD-J disc has one), since the discriminator trait function takes only `&UdfFs` and can't read jar contents. parse() does the real com/dbp/ check — a non-dbp disc gets parsed-as-dbp, archive_has_dbp returns false, parse() returns None, and we fall through. Diagnostic noise: parsers_detected includes "dbp" on non-dbp BD-J discs. Real fix is refactoring the DetectFn signature to take a SectorReader; deferred. 7 unit tests cover the TextField extraction, language detection (simple + compound: "Brazilian Portuguese", "Castilian Spanish", "Canadian French", "Latin American Spanish", "Australian English" plus the disc-corpus typo "Austrailian English"), SDH/Forced/RNIB qualifier detection, and Commentary/Descriptive purpose detection. Don't-guess discipline preserved: unknown languages return "" (consumer falls back to MPLS spec data via fill_defaults).	2026-05-10 13:15:07 -07:00