2 Commits

Include renames

Author	SHA1	Message	Date
MattJackson	92f34a289e	labels: refactor pixelogic + ctrm onto shared platform + hardening ... Closes the platform unification: every label parser now routes purpose/qualifier/codec classification through one source of truth (vocab.rs) instead of N hand-rolls, and every binary-blob byte scanner goes through one helper (text::extract_ascii_strings). pixelogic.rs: - Drop local extract_strings (~20 lines) — use text::extract_ascii_strings. - HARDENING: replace with skip-unknown-component + trace log. Pre-refactor behavior: any single uncatalogued token part (e.g. a future codec ID, new framework variant) silently dropped the entire stream record. New behavior: skip just the unknown part, surface what we know about the stream. - 8 new unit tests cover basic audio/subtitle paths, commentary, descriptive, region variant, the new skip-unknown-component regression, and the non-audio/non-subtitle early-out. ctrm.rs: - Replace with vocab::purpose(&name). Now word-boundary matched — 'Commenter Pro Track' no longer false-matches Commentary. - Replace with vocab::qualifier(&name). Same word-boundary tightening, plus picks up Forced and DescriptiveService for free. - Preserved structural commentary signal via as a fallback when name is silent (e.g. 'audio_commentary_1.name=Track 2'). - 6 new unit tests including the 'Commenter' false-positive regression and the SDH-only-on-subtitles boundary. text.rs: - Drop module-level dead_code allow now that pixelogic uses extract_ascii_strings. Net: all 5 framework parsers now on the unified platform. Future work (deluxe Phase D, paramount/criterion XML hardening) builds on the same scaffolding. Precommit green.	2026-05-10 15:33:22 -07:00
MattJackson	4ec75a03f2	labels: shared platform (vocab/text/jar) + dbp refactor ... Establishes the shared infrastructure layer for label parsers so that Java-touching parsers (dbp, deluxe) don't reimplement jar walking and all parsers route language/purpose/qualifier classification through one source of truth instead of N hand-rolls. New modules: vocab.rs expanded from 27 -> ~370 lines + lang(text) -> Option<&'static str> (English/multi-word -> ISO 639-2; ~45 languages, compound phrases like 'Brazilian Portuguese' and 'Castilian Spanish') + purpose(text) -> LabelPurpose (Commentary, Descriptive, Score, Ime; word-boundary matched) + qualifier(text) -> LabelQualifier (SDH, Forced, DescriptiveService) + has_word internal primitive — enforces word-boundary matching so 'Commenter' no longer matches 'commentary' and 'engineering' no longer matches 'english'. Existing parsers used .contains() and got lucky on the corpus; vocab now guarantees the boundary in one place. 20+ unit tests. text.rs NEW (~85 lines) + extract_ascii_strings(data, min_len) — promoted from two near-duplicate copies (pixelogic min=4, dbp min=5); threshold passed in. 7 unit tests including trailing-without-terminator + high-bit-byte handling. jar.rs NEW (~120 lines) + for_each_jar(reader, udf, fn) — walk every top-level .jar under /BDMV/JAR/, yield to callback. + has_path_prefix(archive, prefix) — cheap 'is this MY framework's jar?' check via central-dir filenames. + for_each_class(archive, fn) — parse every .class entry through class_reader, yield (name, &ClassFile). + try_each_class(archive, fn) — same with early-return on first Some(R) match. Refactored: dbp.rs v2 on the new platform: - dropped extract_printable raw byte scan - dropped its own English -> ISO 639-2 map - dropped its own parse_attributes hand-roll + iterates CpInfo::Utf8 via class_reader (structurally clean, no false-positive risk from method bytecode bytes) + routes language/purpose/qualifier through vocab All 7 prior dbp tests still pass; +2 new ones cover vocab routing. dead-code allows on text.rs (extract_ascii_strings) and jar.rs (try_each_class) come off when pixelogic and deluxe land — they're staged for next steps. Precommit green (cargo +1.86 fmt + clippy + test).	2026-05-10 15:16:25 -07:00