mirror of
https://github.com/freemkv/libfreemkv.git
synced 2026-10-07 18:13:10 +00:00
Matthew Jackson
6e14fc0c0c
Security - Remove the unsafe Vec::set_len over recycled sector buffers — UB reachable from safe code (GHSA-j8ww-f5fg-9pmh, low). Uses Vec::resize; pooling unchanged. CI / tooling - clippy on stable with the MSRV single-sourced from Cargo.toml; cargo-deny dependency-audit gate with first-party git sources allowed (#15); audience-based comment-guard (#17). Docs - README (keydb ownership, BD-J parser count), drive-access transport/reset notes, mux timeline module-doc links.
70 lines
2.6 KiB
YAML
70 lines
2.6 KiB
YAML
name: Release
|
|
|
|
on:
|
|
push:
|
|
tags:
|
|
- 'v*'
|
|
# NOT the release-candidate tags. Every push to `qa` stamps a
|
|
# v<version>-rc<N> so a run can be named, and 'v*' matches those too —
|
|
# which would have this workflow build and PUBLISH a GitHub release for
|
|
# every candidate, including the red ones.
|
|
- '!v*-rc*'
|
|
|
|
permissions:
|
|
contents: write
|
|
|
|
jobs:
|
|
verify:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
- name: Verify Cargo.toml version matches tag
|
|
run: |
|
|
CARGO_VER="v$(grep '^version' Cargo.toml | head -1 | sed 's/.*"\(.*\)"/\1/')"
|
|
if [ "$CARGO_VER" != "${{ github.ref_name }}" ]; then
|
|
echo "::error::Cargo.toml says $CARGO_VER but tag is ${{ github.ref_name }}"
|
|
exit 1
|
|
fi
|
|
echo "Version match: $CARGO_VER"
|
|
|
|
# Tests run as a PARALLEL TRIPWIRE: they fail the run if they fail, but the
|
|
# publish/release jobs do NOT `needs:` this job. The tag decision was already
|
|
# gated by the local precommit (same MSRV, same commit). Binary consumers
|
|
# (freemkv/autorip/bdemu) git-tag-pin libfreemkv and therefore start building
|
|
# the instant this tag exists — so this test job and the crates.io publish
|
|
# below must NOT sit on their critical path.
|
|
test:
|
|
needs: verify
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
- id: msrv
|
|
shell: bash
|
|
run: echo "v=$(grep -m1 '^rust-version' Cargo.toml | sed -E 's/.*\"([^\"]+)\".*/\1/')" >> "$GITHUB_OUTPUT"
|
|
- uses: dtolnay/rust-toolchain@master
|
|
with:
|
|
toolchain: ${{ steps.msrv.outputs.v }}
|
|
- uses: Swatinem/rust-cache@v2
|
|
# Cargo.lock is now committed (issue #15), but --locked is still omitted:
|
|
# the sibling path-patch layout resolves the freemkv crates as path
|
|
# packages, which --locked can't satisfy.
|
|
- run: cargo test
|
|
|
|
# NOTE: there is no crates.io publish job. libfreemkv is git-tag-only
|
|
# (`package.publish = false` — it git-deps the firmware crate freemkv-unlock,
|
|
# which never ships to crates.io). Every consumer git-tag-pins libfreemkv via
|
|
# a committed [patch.crates-io]; the git tag itself IS the release artifact.
|
|
# A `cargo publish` here fails hard on `publish = false`, so it was removed.
|
|
|
|
release:
|
|
# Only needs `verify`; the GitHub Release can be cut as soon as the version
|
|
# check passes, in parallel with test + publish.
|
|
needs: verify
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v7
|
|
- name: Create GitHub Release
|
|
uses: softprops/action-gh-release@v3
|
|
with:
|
|
generate_release_notes: true
|