v1.0.0-rc.5.1: bump version (unified release)

A keydb can hand out a per-disc terminal Key::Unit (a UK entry keyed on
disc_hash). Unlike a derived key (Device/Processing/Media/Volume), a
terminal UK is applied as-is by Disc::decrypt_with: it is NOT re-derived
through the MKB-verified AACS resolver, so a UK entry whose hash matches
the disc but whose key bytes are wrong is only disproved by descrambling
real ciphertext.

KeydbSource inherited the default needs_samples() == false, so on the
autorip auto-resume / mux-worker path (which samples units only when some
source reports needs_samples()) a keydb-only resolve ran with empty
samples and committed a wrong UK as success, muxing undecryptable video
while reporting done. The CLI was unaffected because it always samples.

Override needs_samples() to true on KeydbSource so every consumer samples
encrypted units before resolving and a wrong keydb UK is rejected on all
paths. Regression test asserts the override.

.github/workflows/release.yml

@@ -22,26 +22,35 @@ jobs:
           fi
           echo "Version match: $CARGO_VER"
 
+  # Tests run as a PARALLEL TRIPWIRE: they fail the run if they fail, but the
+  # release job does NOT `needs:` this job. The tag decision was already gated by
+  # the local precommit (same Rust 1.86, same commit).
+  #
+  # freemkv-keysources is a library — Cargo.lock isn't tracked, so --locked
+  # would always fail (no lockfile to lock against on a fresh runner). Its
+  # libfreemkv dep resolves from crates.io (the dev .cargo/config.toml patch is
+  # gitignored and absent on the runner), so libfreemkv must already be published
+  # at this version — the release script enforces that ordering before tagging.
   test:
     needs: verify
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5
       - uses: dtolnay/rust-toolchain@1.86.0
-      # freemkv-keysources is a library — Cargo.lock isn't tracked, so --locked
-      # would always fail (no lockfile to lock against on a fresh runner). Its
-      # libfreemkv dep resolves from crates.io (the dev .cargo/config.toml patch
-      # is gitignored and absent on the runner), so libfreemkv must already be
-      # published at this version — the release script enforces that ordering.
+      - uses: Swatinem/rust-cache@v2
       - run: cargo test
 
   # NOTE: the crates.io publish is driven by the maintainer's release tooling
   # from local credentials, not from CI — this repo has no CARGO_REGISTRY_TOKEN
-  # secret. CI here only verifies the version/tag match, runs tests, and cuts
-  # the GitHub Release.
+  # secret. release.sh runs `cargo publish --no-verify` locally. CI here only
+  # verifies the version/tag match, runs tests (tripwire), and cuts the GitHub
+  # Release. The binaries git-tag-pin keysources, so they don't wait on the
+  # crates.io publish — it serves external consumers in parallel.
 
   release:
-    needs: test
+    # Only needs `verify`; the GitHub Release is cut as soon as the version
+    # check passes, in parallel with the test tripwire.
+    needs: verify
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v5

CODE_OF_CONDUCT.md

@@ -0,0 +1,83 @@
+# Contributor Covenant Code of Conduct
+
+## Our Pledge
+
+We as members, contributors, and leaders pledge to make participation in our community a harassment-free experience for everyone, regardless of age, body size, visible or invisible disability, ethnicity, sex characteristics, gender identity and expression, level of experience, education, socio-economic status, nationality, personal appearance, race, caste, color, religion, or sexual identity and orientation.
+
+We pledge to act and interact in ways that contribute to an open, welcoming, diverse, inclusive, and healthy community.
+
+## Our Standards
+
+Examples of behavior that contributes to a positive environment for our community include:
+
+* Demonstrating empathy and kindness toward other people
+* Being respectful of differing opinions, viewpoints, and experiences
+* Giving and gracefully accepting constructive feedback
+* Accepting responsibility and apologizing to those affected by our mistakes, and learning from the experience
+* Focusing on what is best not just for us as individuals, but for the overall community
+
+Examples of unacceptable behavior include:
+
+* The use of sexualized language or imagery, and sexual attention or advances of any kind
+* Trolling, insulting or derogatory comments, and personal or political attacks
+* Public or private harassment
+* Publishing others' private information, such as a physical or email address, without their explicit permission
+* Other conduct which could reasonably be considered inappropriate in a professional setting
+
+## Enforcement Responsibilities
+
+Community leaders are responsible for clarifying and enforcing our standards of acceptable behavior and will take appropriate and fair corrective action in response to any behavior that they deem inappropriate, threatening, offensive, or harmful.
+
+Community leaders have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, and will communicate reasons for moderation decisions when appropriate.
+
+## Scope
+
+This Code of Conduct applies within all community spaces, and also applies when an individual is officially representing the community in public spaces. Examples of representing our community include using an official e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event.
+
+## Enforcement
+
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported to the community leaders responsible for enforcement at owner@example.invalid. All complaints will be reviewed and investigated promptly and fairly.
+
+All community leaders are obligated to respect the privacy and security of the reporter of any incident.
+
+## Enforcement Guidelines
+
+Community leaders will follow these Community Impact Guidelines in determining the consequences for any action they deem in violation of this Code of Conduct:
+
+### 1. Correction
+
+**Community Impact**: Use of inappropriate language or other behavior deemed unprofessional or unwelcome in the community.
+
+**Consequence**: A private, written warning from community leaders, providing clarity around the nature of the violation and an explanation of why the behavior was inappropriate. A public apology may be requested.
+
+### 2. Warning
+
+**Community Impact**: A violation through a single incident or series of actions.
+
+**Consequence**: A warning with consequences for continued behavior. No interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, for a specified period of time. This includes avoiding interactions in community spaces as well as external channels like social media. Violating these terms may lead to a temporary or permanent ban.
+
+### 3. Temporary Ban
+
+**Community Impact**: A serious violation of community standards, including sustained inappropriate behavior.
+
+**Consequence**: A temporary ban from any sort of interaction or public communication with the community for a specified period of time. No public or private interaction with the people involved, including unsolicited interaction with those enforcing the Code of Conduct, is allowed during this period. Violating these terms may lead to a permanent ban.
+
+### 4. Permanent Ban
+
+**Community Impact**: Demonstrating a pattern of violation of community standards, including sustained inappropriate behavior, harassment of an individual, or aggression toward or disparagement of classes of individuals.
+
+**Consequence**: A permanent ban from any sort of public interaction within the community.
+
+## Attribution
+
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 2.1, available at [https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1].
+
+Community Impact Guidelines were inspired by [Mozilla's code of conduct enforcement ladder][Mozilla CoC].
+
+For answers to common questions about this code of conduct, see the FAQ at [https://www.contributor-covenant.org/faq][FAQ]. Translations are available at [https://www.contributor-covenant.org/translations][translations].
+
+[homepage]: https://www.contributor-covenant.org
+[v2.1]: https://www.contributor-covenant.org/version/2/1/code_of_conduct.html
+[Mozilla CoC]: https://github.com/mozilla/diversity
+[FAQ]: https://www.contributor-covenant.org/faq
+[translations]: https://www.contributor-covenant.org/translations

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "freemkv-keysources"
-version = "1.0.0-rc.3.1"
+version = "1.0.0-rc.5.1"
 edition = "2024"
 rust-version = "1.86"
 license = "AGPL-3.0-only"
@@ -11,7 +11,7 @@ categories = ["multimedia"]
 
 [dependencies]
 # The crate provides the `KeySource` trait + `Key`/`DiscInputs` types these impls fill.
-libfreemkv = "1.0.0-rc.3"
+libfreemkv = "1.0.0-rc.5.1"
 # OnlineSource: POST disc inputs + samples to a key service over HTTP.
 ureq = { version = "2", features = ["json"] }
 serde_json = "1"

src/keydb.rs

@@ -106,6 +106,25 @@ impl KeySource for KeydbSource {
         KeydbSource::host_certs(self)
     }
 
+    /// The keydb can hand out a per-disc **terminal** `Key::Unit` (a UK entry
+    /// keyed on `disc_hash` alone — see `candidates_from`). Unlike a derived key
+    /// (Device/Processing/Media/Volume), a terminal UK is applied as-is by
+    /// `Disc::decrypt_with`: it is NOT re-derived through the MKB-verified AACS
+    /// resolver, so a UK entry whose hash matches the disc but whose key bytes
+    /// are wrong would commit and mux undecryptable video as "success". The only
+    /// thing that disproves a wrong UK is descrambling real ciphertext, so this
+    /// source requires content samples — without them `decrypt_with` skips
+    /// validation and the wrong UK is taken. Returning `true` makes every
+    /// consumer (autorip resume/mux-worker AND the CLI) sample units before
+    /// resolving, so a keydb UK is ciphertext-validated on every path.
+    fn needs_samples(&self) -> bool {
+        true
+    }
+
+    fn label(&self) -> &'static str {
+        "keydb"
+    }
+
     fn next_key(&mut self, inputs: &DiscInputs) -> Option<Key> {
         // On the first ask, parse the keydb once and build the ordered candidate
         // list; later asks just advance the cursor. A missing/unreadable keydb
@@ -232,6 +251,22 @@ mod tests {
         assert!(KeydbSource::candidates_from(&db, &inputs("0xaabb")).is_empty());
     }
 
+    /// Regression: a keydb can hand out a per-disc terminal `Key::Unit` that
+    /// `Disc::decrypt_with` applies WITHOUT re-deriving through the MKB-verified
+    /// AACS resolver. The only thing that disproves a wrong UK is descrambling
+    /// ciphertext, so the source MUST request content samples — otherwise the
+    /// autorip resume/mux-worker path (which only samples when some source
+    /// reports `needs_samples()`) resolves with empty samples and commits a
+    /// wrong UK as success. Was `false` (inherited default); must be `true`.
+    #[test]
+    fn keydb_source_needs_samples() {
+        let src = KeydbSource::new("/nonexistent/path/keydb.cfg");
+        assert!(
+            src.needs_samples(),
+            "keydb emits terminal Key::Unit entries that need ciphertext validation"
+        );
+    }
+
     /// No keydb (or a LibreDrive deployment) → no host credentials, not an
     /// error. (The positive parse is NOT tested here — it would require host
     /// key material, which must never appear in code.)

src/online.rs

@@ -319,6 +319,10 @@ impl KeySource for OnlineSource {
         true
     }
 
+    fn label(&self) -> &'static str {
+        "online"
+    }
+
     fn errored(&self) -> bool {
         self.errored
     }

src/paths.rs

@@ -183,13 +183,13 @@ mod tests {
     #[test]
     fn unix_default_is_home_dotconfig() {
         with_env(
-            &[("HOME", Some("/home/matt")), ("XDG_CONFIG_HOME", None)],
+            &[("HOME", Some("/u/me")), ("XDG_CONFIG_HOME", None)],
             || {
                 let paths = keydb_search_paths();
                 assert_eq!(paths.len(), 1, "just the $HOME/.config default");
                 assert_eq!(
                     paths[0],
-                    PathBuf::from("/home/matt")
+                    PathBuf::from("/u/me")
                         .join(".config")
                         .join("freemkv")
                         .join("keydb.cfg"),
@@ -205,15 +205,15 @@ mod tests {
     fn unix_honours_xdg_config_home_first() {
         with_env(
             &[
-                ("XDG_CONFIG_HOME", Some("/home/matt/.cfg")),
-                ("HOME", Some("/home/matt")),
+                ("XDG_CONFIG_HOME", Some("/u/me/.cfg")),
+                ("HOME", Some("/u/me")),
             ],
             || {
                 let paths = keydb_search_paths();
                 assert_eq!(paths.len(), 2, "XDG dir + $HOME/.config fallback");
                 assert_eq!(
                     paths[0],
-                    PathBuf::from("/home/matt/.cfg")
+                    PathBuf::from("/u/me/.cfg")
                         .join("freemkv")
                         .join("keydb.cfg"),
                     "XDG_CONFIG_HOME, when set, is searched before ~/.config"