mirror of
https://github.com/freemkv/freemkv-keysources.git
synced 2026-10-07 18:13:11 +00:00
Matthew Jackson
599422ef22
CI/lint hardening since v1.6.14: clippy on stable with the MSRV single-sourced from Cargo.toml, cargo-deny dependency-audit gate with first-party git sources allowed (#15), and audience-based comment-guard (#17). No library code changes.
1.1 KiB
1.1 KiB
src/online.rs — OnlineSource::query return contract
The return type draws THE distinction this source exists to draw:
Ok(non-empty)— the service answered with a key.Ok(empty)— the service ANSWERED and holds no key for this disc, or this source had nothing to ask with (no service configured, a misconfigured URL, an over-cap MKB, too few samples). A genuine miss; the resolver moves to the next source andE7022is the right verdict.Err(..)— the service could not answer: unreachable, timed out, DNS failed, returned 5xx, rejected the token (401/403), rate-limited (429), or replied with something unreadable. NOTHING is known about whether a key exists. Collapsing this intoOk(empty)is the bug this signature fixes: a seven-hour run of HTTP 502s was reported to operators asE7022 No key source has a decryption key for this disc, and they went hunting for a VUK when the correct action was to wait.
&self: one-shot is the resolver's contract (each source's
get_unit_keys is called once), so no per-call latch is needed.