Matthew Jackson
bce5f36ef2
Fix two re-audit findings: 1. LOW (correctness): run_cert_handshake_with_anchors computed the up-front cert-skip has_v2 gate WITHOUT allow_p256, unlike attempt_one_cert. In production (allow_p256=false) a dead-v1 cert carrying v2 creds was not skipped up front, reached the drive, failed the step-7 self-verify, and consumed a MAX_CERT_ATTEMPTS slot -- so [dead+v2 x3, valid] exhausted the cap and never tried the valid cert. Mirror attempt_one_cert's gate exactly. Add a regression test. 2. LOW (key hygiene): add the zeroize crate and wipe sensitive key material on drop -- HostCert private keys, AacsAuth/CertHandshake derived bus_key/volume_id/read_data_key (ZeroizeOnDrop, non-secret fields skipped), the ephemeral AKE scalars and raw private-scalar byte buffers (Zeroizing). BigUint scalars/shared-x are a documented best-effort residual (num-bigint exposes no zeroization). Debug redaction and the EC math are untouched.
freemkv-unlock
The unlock layer for the freemkv toolchain.
An unlocker removes a drive-level bus-encryption barrier so the drive serves readable (de-bus'd / de-scrambled) sectors. Content-key decryption is a separate concern — the consumer's job.
This crate defines the Unlocker contract and a generic SCSI transport
contract, and holds the self-contained unlocker modules. The consumer
(libfreemkv) depends on this crate and
dispatches through all_unlockers(); it never names an individual unlocker, and
clients of libfreemkv are oblivious to unlockers entirely (as they are to the
SCSI layer).
use freemkv_unlock::UnlockError;
// Drive-prep: try each unlocker's feature unlock until one claims the drive.
// `NotApplicable` means "not this unlocker's drive" — move on; a transport
// error means a dead bus — abort. `unlock_bus` follows the same contract for
// removing per-disc bus encryption.
for u in freemkv_unlock::all_unlockers() {
match u.unlock_features(&mut scsi, &ctx) {
Ok(unlocked) => return Ok(unlocked),
Err(UnlockError::NotApplicable) => continue,
Err(e) => return Err(e),
}
}
To remove an unlocker, delete its module directory and its one line in
all_unlockers() — nothing else changes.
License
freemkv-unlock's own source is MIT — see LICENSE.
src/ld/profiles.json bundles volatile, RAM-only LibreDrive microcode
authored and owned by the MakeMKV team (GuinpinSoft inc.) — Copyright (c)
MakeMKV team, all rights reserved. That microcode is third-party proprietary
material, not covered by the MIT license; no ownership is claimed. See
NOTICE. With thanks to the MakeMKV team for
LibreDrive.