pq/libfreemkv
1
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

ci: run the dependents' test suites, not just a type-check

Browse Source 
The `consumers` job checked out all five dependents against this commit and
ran `cargo check --all-targets`. That proves they still COMPILE, which
catches a changed signature and nothing else. The failures worth catching
here keep every signature intact and change behaviour: the library still
builds, the dependent still builds, and the dependent's tests are what go
red. Those never ran.

Run their suites instead. Same checkouts, same patched paths — only the
verb changes.
This commit is contained in:
Matthew Jackson
2026-08-08 08:46:17 -07:00
parent 835e97ce71
commit 237794a6ea
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/ci.yml
+9 -5
View File
@@ -187,13 +187,17 @@ jobs:
freemkv freemkv
autorip autorip
bdemu bdemu
- run: cargo check --all-targets # `cargo check` alone only proves the dependents still COMPILE against
# this commit. It cannot see a behavioural change — the library keeps its
# signatures and a dependent's tests start failing. That is the shape of
# every defect worth catching here, so run their suites too.
- run: cargo test --tests
working-directory: freemkv-keysources working-directory: freemkv-keysources
- run: cargo check --all-targets - run: cargo test --tests
working-directory: freemkv-engine working-directory: freemkv-engine
- run: cargo check --all-targets - run: cargo test --tests
working-directory: freemkv working-directory: freemkv
- run: cargo check --all-targets - run: cargo test --tests
working-directory: autorip working-directory: autorip
- run: cargo check --all-targets - run: cargo test --tests
working-directory: bdemu working-directory: bdemu