mirror of
https://github.com/freemkv/libfreemkv.git
synced 2026-10-07 18:13:10 +00:00
Matthew Jackson
cf2171e11a
MKV read-back carries display shape, colour, frame rate, content encodings and BCP47 language, and drops malformed blocks with a count. The FMKV header carries display aspect, CICP, labels, chapters and format. Live reads refuse a zero read batch (E9085) and treat a stopped read as a stop. freemkv-unlock becomes a version dep with a git-tag override; dependency bumps (#27, #28); LPCM keeps its source bit depth; 1.8.0 changelog.
181 lines
7.4 KiB
YAML
181 lines
7.4 KiB
YAML
name: qa
|
|
|
|
# ── The qa gate: "is this production worth?" ────────────────────────────────
|
|
#
|
|
# dev -> qa -> main.
|
|
#
|
|
# `dev` is for committing often. ci.yml answers "is it green" in minutes with
|
|
# fmt, clippy and the unit suite, so a mistake surfaces while it is still cheap
|
|
# to fix. `qa` is the release-candidate branch, and THIS workflow is the claim
|
|
# that a commit is production worth: everything expensive that can run without
|
|
# physical media. `main` only ever receives a qa that went green here.
|
|
#
|
|
# Sibling repos are checked out at `qa`, NOT `dev`. A qa run that resolved its
|
|
# dependencies from dev tips would be validating a combination that is not the
|
|
# one being released, which is the exact failure this branch exists to prevent.
|
|
#
|
|
# What this gate CANNOT cover: `disc://` and real `iso://` need physical media,
|
|
# and no hosted runner has an optical drive or the image hoard. That coverage
|
|
# lives in freemkv's qa.yml (the real-media EC2 matrix), not in this file.
|
|
on:
|
|
push:
|
|
branches: [qa]
|
|
workflow_dispatch:
|
|
|
|
# Rapid dev pushes supersede their own in-progress runs instead of stacking.
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
# Single source of truth for the MSRV — see ci.yml. Jobs that build/test AT
|
|
# the MSRV read `needs.resolve-msrv.outputs.v` from Cargo.toml's rust-version;
|
|
# clippy (cross-lint) runs on stable instead.
|
|
resolve-msrv:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 5
|
|
outputs:
|
|
v: ${{ steps.msrv.outputs.v }}
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
|
|
- id: msrv
|
|
shell: bash
|
|
run: echo "v=$(grep -m1 '^rust-version' Cargo.toml | sed -E 's/.*\"([^\"]+)\".*/\1/')" >> "$GITHUB_OUTPUT"
|
|
|
|
# ── Name the candidate ────────────────────────────────────────────────
|
|
#
|
|
# Every push to `qa` is a release candidate, so every push gets a tag:
|
|
# v<version>-rc<N>, N incrementing. That is the answer to "which build is on
|
|
# qa right now, and is it the one I tested?" — a question that otherwise gets
|
|
# answered from memory.
|
|
#
|
|
# This runs FIRST and does not depend on the gates, deliberately. A red
|
|
# candidate needs a name more than a green one does: "rc3 failed
|
|
# release-tests on windows" is a sentence you can act on; "qa is red" is not.
|
|
# Red on qa is a working gate, not an incident — it is the branch saying this
|
|
# is not production worth yet. Fix on dev, get dev green, push qa again.
|
|
#
|
|
# release.yml excludes v*-rc* so a candidate never publishes a release.
|
|
rc-tag:
|
|
# A manual dispatch from another branch must not stamp a candidate.
|
|
if: github.ref_name == 'qa'
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 10
|
|
permissions:
|
|
contents: write
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
|
|
with:
|
|
fetch-depth: 0
|
|
- name: Stamp the next rc
|
|
shell: bash
|
|
run: |
|
|
set -euo pipefail
|
|
v=$(sed -n 's/^version = "\(.*\)"/\1/p' Cargo.toml | head -1)
|
|
[ -n "$v" ] || { echo "no version in Cargo.toml" >&2; exit 1; }
|
|
# Numeric sort on the rc ordinal: -rc10 must beat -rc9, and a plain
|
|
# lexical sort gets that backwards from the tenth candidate on.
|
|
# Retry on a lost race for the same ordinal: refetch tags, recompute.
|
|
for attempt in 1 2 3 4 5; do
|
|
git fetch --tags --force origin
|
|
n=$(git tag -l "v$v-rc*" | sed "s|^v$v-rc||" | sort -n | tail -1)
|
|
tag="v$v-rc$(( ${n:-0} + 1 ))"
|
|
git tag "$tag"
|
|
git push origin "$tag" && break
|
|
git tag -d "$tag"
|
|
[ "$attempt" -lt 5 ] || { echo "could not push an rc tag" >&2; exit 1; }
|
|
done
|
|
echo "### Candidate \`$tag\`" >> "$GITHUB_STEP_SUMMARY"
|
|
|
|
# The debug suite runs on every dev push. Release is a DIFFERENT build:
|
|
# overflow checks are off, debug_assert! is compiled out, and inlining
|
|
# changes what the optimiser can prove. A test that only passes in debug is
|
|
# a test that never guarded the binary anyone actually ships.
|
|
release-tests:
|
|
needs: resolve-msrv
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os: ['ubuntu-latest', 'macos-latest']
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 60
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
|
|
with:
|
|
path: libfreemkv
|
|
- uses: freemkv/.github/.github/actions/checkout-siblings@v1
|
|
with:
|
|
checkout: freemkv-unlock
|
|
patch: freemkv-unlock
|
|
self: libfreemkv
|
|
- uses: dtolnay/rust-toolchain@master
|
|
with:
|
|
toolchain: ${{ needs.resolve-msrv.outputs.v }}
|
|
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2
|
|
with:
|
|
workspaces: libfreemkv
|
|
- run: cargo test --release --tests
|
|
working-directory: libfreemkv
|
|
- run: cargo test --release --doc
|
|
working-directory: libfreemkv
|
|
|
|
# Independent decoder/remux verification uses generated media and belongs
|
|
# on qa, alongside the release suite. Also runnable manually on a branch.
|
|
ffmpeg-validation:
|
|
uses: ./.github/workflows/ffmpeg-validation.yml
|
|
permissions:
|
|
contents: read
|
|
|
|
# clippy's output is target-dependent: cfg-gated code only gets linted on
|
|
# the target it compiles for. Linting solely on the dev machine's host
|
|
# target is how a lint that CI rejects reaches a push.
|
|
cross-lint:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 30
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
|
|
with:
|
|
path: libfreemkv
|
|
- uses: freemkv/.github/.github/actions/checkout-siblings@v1
|
|
with:
|
|
checkout: freemkv-unlock
|
|
patch: freemkv-unlock
|
|
self: libfreemkv
|
|
# clippy runs on stable (matches ci.yml's lint job); build/test stay on
|
|
# the MSRV pin. See ci.yml for why the lint toolchain need not be the MSRV.
|
|
- uses: dtolnay/rust-toolchain@stable
|
|
with:
|
|
toolchain: stable
|
|
components: clippy
|
|
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2
|
|
with:
|
|
workspaces: libfreemkv
|
|
- run: cargo clippy --all-targets -- -D warnings
|
|
working-directory: libfreemkv
|
|
|
|
# Windows compiles the tests but does not run them, matching the policy
|
|
# ci.yml already set. The value here is codegen: the #[cfg(windows)] halves
|
|
# of the SCSI transport and platform layers compile on no other runner, so
|
|
# without this they are first built at release time.
|
|
windows-build:
|
|
needs: resolve-msrv
|
|
runs-on: windows-latest
|
|
timeout-minutes: 45
|
|
steps:
|
|
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7
|
|
with:
|
|
path: libfreemkv
|
|
- uses: freemkv/.github/.github/actions/checkout-siblings@v1
|
|
with:
|
|
checkout: freemkv-unlock
|
|
patch: freemkv-unlock
|
|
self: libfreemkv
|
|
- uses: dtolnay/rust-toolchain@master
|
|
with:
|
|
toolchain: ${{ needs.resolve-msrv.outputs.v }}
|
|
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2
|
|
with:
|
|
workspaces: libfreemkv
|
|
- run: cargo build --release --tests
|
|
working-directory: libfreemkv
|