The Windows UI needs current winsafe, whose real minimum is 1.89 (its manifest under-declares 1.87 while it uses NonNull::from_ref). Rather than stop at the minimum, this goes to current stable and fixes what that costs. The counter-intuitive result: 1.97 is CHEAPER than 1.89. libfreemkv had 54 clippy errors at 1.89 and 6 at 1.97, because clippy tightened the noisy collapsible_if lint in between. Stopping at the minimum would have been the most expensive choice available. Roughly 47 lints across the eight repos, the large majority auto-fixed: libfreemkv 6, freemkv-engine 14, bdemu 8, freemkv-keysources 7, autorip 6, freemkv-unlock 3, freemkv-i18n 3. The hand-fixed ones are a descending sort to sort_by_key(Reverse), four manual checked-division sites, a loop counter replaced by enumerate, and a loop whose first let-else became a while-let. Worth recording for whoever bumps next: clippy is MSRV-AWARE. Those 54 lints only appear once the crate DECLARES 1.89 or later, because let-chains become available. A bare `cargo +1.89 clippy` against a manifest still pinned at 1.87 reports clean and is meaningless — gate with the real precommit script, which is also the only thing that covers build scripts. The pin still sits below the Mac default, so it keeps doing its job: catching lint drift locally before CI sees it.
98 lines
3.7 KiB
Rust
98 lines
3.7 KiB
Rust
fn main() {
|
|
emit_git_suffix();
|
|
|
|
let target = std::env::var("CARGO_CFG_TARGET_OS").unwrap_or_default();
|
|
if target == "macos" {
|
|
println!("cargo:rustc-link-lib=framework=IOKit");
|
|
println!("cargo:rustc-link-lib=framework=CoreFoundation");
|
|
|
|
let out_dir = std::env::var("OUT_DIR").unwrap();
|
|
let obj = format!("{out_dir}/macos_shim.o");
|
|
let lib = format!("{out_dir}/libmacos_scsi.a");
|
|
|
|
// Build the shim for the TARGET arch, not the host's. A bare `cc` on an
|
|
// Apple-Silicon CI runner defaults to arm64, so cross-building to
|
|
// x86_64-apple-darwin would link a host-arch object against x86_64 Rust
|
|
// code → "Undefined symbols for architecture x86_64". (Still raw `cc`,
|
|
// not the `cc` crate, which breaks IOKit exclusive access.)
|
|
let target_arch = std::env::var("CARGO_CFG_TARGET_ARCH").unwrap_or_default();
|
|
let clang_arch: &str = if target_arch == "aarch64" {
|
|
"arm64"
|
|
} else {
|
|
&target_arch // x86_64 → x86_64
|
|
};
|
|
|
|
std::process::Command::new("cc")
|
|
.args([
|
|
"-arch",
|
|
clang_arch,
|
|
"-c",
|
|
"src/scsi/macos_shim.c",
|
|
"-o",
|
|
&obj,
|
|
"-framework",
|
|
"IOKit",
|
|
"-framework",
|
|
"CoreFoundation",
|
|
"-Wall",
|
|
"-O2",
|
|
])
|
|
.status()
|
|
.expect("failed to compile macos_shim.c");
|
|
|
|
std::process::Command::new("ar")
|
|
.args(["rcs", &lib, &obj])
|
|
.status()
|
|
.expect("failed to create static lib");
|
|
|
|
println!("cargo:rustc-link-search=native={out_dir}");
|
|
println!("cargo:rustc-link-lib=static=macos_scsi");
|
|
println!("cargo:rerun-if-changed=src/scsi/macos_shim.c");
|
|
}
|
|
}
|
|
|
|
/// Bake the git short hash into the build as `GIT_SUFFIX` so any muxed MKV or
|
|
/// FVI index is traceable to the exact source revision (e.g. ` (g835cc99)`).
|
|
/// Empty when git or the repo is unavailable (e.g. a crates.io tarball build),
|
|
/// leaving just the package version. Always emitted so `env!("GIT_SUFFIX")`
|
|
/// resolves on every target.
|
|
fn emit_git_suffix() {
|
|
// Version label for the muxing-app / FVI generator tag. `FREEMKV_BUILD_LABEL`
|
|
// overrides the Cargo package version when set (non-empty) — used to stamp a
|
|
// pre-release/test build without bumping Cargo.toml and disturbing the
|
|
// tag-pinned [patch] version matching. Unset → the package version.
|
|
let version = std::env::var("FREEMKV_BUILD_LABEL")
|
|
.ok()
|
|
.filter(|s| !s.trim().is_empty())
|
|
.or_else(|| std::env::var("CARGO_PKG_VERSION").ok())
|
|
.unwrap_or_default();
|
|
println!("cargo:rustc-env=FREEMKV_VERSION={version}");
|
|
println!("cargo:rerun-if-env-changed=FREEMKV_BUILD_LABEL");
|
|
|
|
let suffix = git_short_hash()
|
|
.map(|h| format!(" (g{h})"))
|
|
.unwrap_or_default();
|
|
println!("cargo:rustc-env=GIT_SUFFIX={suffix}");
|
|
|
|
// Re-run when HEAD (or the branch it points at) moves so the stamp stays
|
|
// current without a clean rebuild.
|
|
println!("cargo:rerun-if-changed=.git/HEAD");
|
|
if let Ok(head) = std::fs::read_to_string(".git/HEAD")
|
|
&& let Some(ref_path) = head.strip_prefix("ref: ")
|
|
{
|
|
println!("cargo:rerun-if-changed=.git/{}", ref_path.trim());
|
|
}
|
|
}
|
|
|
|
fn git_short_hash() -> Option<String> {
|
|
let out = std::process::Command::new("git")
|
|
.args(["rev-parse", "--short=7", "HEAD"])
|
|
.output()
|
|
.ok()?;
|
|
if !out.status.success() {
|
|
return None;
|
|
}
|
|
let h = String::from_utf8(out.stdout).ok()?.trim().to_string();
|
|
if h.is_empty() { None } else { Some(h) }
|
|
}
|