mirror of
https://github.com/freemkv/libfreemkv.git
synced 2026-10-07 18:13:10 +00:00
Matthew Jackson
6e14fc0c0c
Security - Remove the unsafe Vec::set_len over recycled sector buffers — UB reachable from safe code (GHSA-j8ww-f5fg-9pmh, low). Uses Vec::resize; pooling unchanged. CI / tooling - clippy on stable with the MSRV single-sourced from Cargo.toml; cargo-deny dependency-audit gate with first-party git sources allowed (#15); audience-based comment-guard (#17). Docs - README (keydb ownership, BD-J parser count), drive-access transport/reset notes, mux timeline module-doc links.
27 lines
1.1 KiB
Markdown
27 lines
1.1 KiB
Markdown
# hex
|
|
|
|
The single hex → bytes parser for the whole workspace.
|
|
|
|
## Why one parser
|
|
|
|
Key material arrives as hex from three third-party sources — the keydb, an
|
|
online key service, and the mapfile's `# freemkv-vid:` comment — and each
|
|
used to parse it slightly differently (one stripped `0x`/`0X`, one stripped
|
|
nothing, one stripped `0x` only). A key written with a prefix one parser
|
|
didn't expect was silently dropped → "can't decrypt" with no error. This is
|
|
the one parser they all call, so the prefix/case/validation rules live in
|
|
exactly one place.
|
|
|
|
## Byte-oriented, not char-oriented
|
|
|
|
Operates on BYTES, not `&str` char indices: the inputs are untrusted, so a
|
|
multi-byte UTF-8 scalar must reject as malformed, never panic on a
|
|
mid-codepoint slice.
|
|
|
|
## `byte()` internals
|
|
|
|
Combines two ASCII hex-digit bytes into one byte. `as char` is intentional:
|
|
for a non-ASCII byte it produces a Latin-1 scalar that `to_digit(16)` then
|
|
rejects — so non-hex (incl. `+`/`-` sign chars) and multi-byte input fail
|
|
cleanly rather than slipping through `from_str_radix`'s sign handling.
|